Bläddra i källkod

fix member to image transition if no images exist

Kylie Jo Swistak 5 år sedan
förälder
incheckning
412cc26860
2 ändrade filer med 6 tillägg och 7 borttagningar
  1. 5 2
      app/carousels/image.rb
  2. 1 5
      app/carousels/member.rb

+ 5 - 2
app/carousels/image.rb

@@ -59,7 +59,10 @@ class ImageCarousel < Carousel
     end
   end
 
-  def self.transition(event, carousel, image)
+  def self.transition(event, carousel, character)
+    # Find image ID
+    image = CharImage.where(keyword: 'Default').find_by(char_id: character.id)
+
     # Update carousel to reflect new information
     carousel.update(
       char_id: nil,
@@ -77,7 +80,7 @@ class ImageCarousel < Carousel
       carousel: carousel,
       reactions: img_reactions,
       embed: character_embed(
-        character: Character.find(image.char_id),
+        character: character,
         event: event,
         section: 'image'
       )

+ 1 - 5
app/carousels/member.rb

@@ -19,13 +19,9 @@ class CharacterCarousel < Carousel
 
     case section
     when 'image'
-      # Find image ID
-      image = CharImage.where(keyword: 'Default')
-        .find_by(char_id: carousel.char_id)
-
       # Transition into an ImageCarousel
       event.message.delete_all_reactions
-      ImageCarousel.transition(event, carousel, image)
+      ImageCarousel.transition(event, carousel, Character.find(carousel.char_id))
     when 'user'
       # Find User
       character = Character.find(carousel.char_id)