#6 pkmn-poll

Merged
kjswis merged 2 commits from PMD/Polling into PMD/master 6 years ago
There is no content yet.
kjswis commented 6 years ago
Owner

Let's use ruby's .each instead of iterating with a integer variable

Should look more like

i = 0
optionsArray.each do |option|
  fields.push({ name: Emoji::LETTERS[i], value: "#{option}\n#{CharAppResponses::INLINE_SPACE}", inline: true })
  i += 1
end

instead of like: for b in 1..a-1 do

Then when you iterate to add reactions, you can say

j = 0
i.times do
  message.react(Emoji::LETTERS[j]
end

Though, for this one you probably can use for b in 0..a do if you really want to

None of this has to be exact, but its cleaner to use ruby's custom for loops for iterations instead of storing a bunch of numbers and iterating

After this is all changed, and rebased, we will also need to add the command description and options

Let's use ruby's `.each` instead of iterating with a integer variable Should look more like ```ruby i = 0 optionsArray.each do |option| fields.push({ name: Emoji::LETTERS[i], value: "#{option}\n#{CharAppResponses::INLINE_SPACE}", inline: true }) i += 1 end ``` instead of like: `for b in 1..a-1 do` Then when you iterate to add reactions, you can say ```ruby j = 0 i.times do message.react(Emoji::LETTERS[j] end ``` Though, for this one you probably can use `for b in 0..a do` if you really want to None of this has to be exact, but its cleaner to use ruby's custom for loops for iterations instead of storing a bunch of numbers and iterating After this is all changed, and rebased, we will also need to add the command description and options
This pull request has been merged successfully!
Sign in to join this conversation.
No Label
No Milestone
No assignee
2 Participants
Loading...
Cancel
Save
There is no content yet.