#6 pkmn-poll

ادغام شده
kjswis 2 کامیت ادغام شده از PMD/Polling به PMD/master 6 سال پیش
هنوز محتوایی ایجاد نشده.
kjswis نظر 6 سال پیش
مالک

Let's use ruby's .each instead of iterating with a integer variable

Should look more like

i = 0
optionsArray.each do |option|
  fields.push({ name: Emoji::LETTERS[i], value: "#{option}\n#{CharAppResponses::INLINE_SPACE}", inline: true })
  i += 1
end

instead of like: for b in 1..a-1 do

Then when you iterate to add reactions, you can say

j = 0
i.times do
  message.react(Emoji::LETTERS[j]
end

Though, for this one you probably can use for b in 0..a do if you really want to

None of this has to be exact, but its cleaner to use ruby's custom for loops for iterations instead of storing a bunch of numbers and iterating

After this is all changed, and rebased, we will also need to add the command description and options

Let's use ruby's `.each` instead of iterating with a integer variable Should look more like ```ruby i = 0 optionsArray.each do |option| fields.push({ name: Emoji::LETTERS[i], value: "#{option}\n#{CharAppResponses::INLINE_SPACE}", inline: true }) i += 1 end ``` instead of like: `for b in 1..a-1 do` Then when you iterate to add reactions, you can say ```ruby j = 0 i.times do message.react(Emoji::LETTERS[j] end ``` Though, for this one you probably can use `for b in 0..a do` if you really want to None of this has to be exact, but its cleaner to use ruby's custom for loops for iterations instead of storing a bunch of numbers and iterating After this is all changed, and rebased, we will also need to add the command description and options
kjswis 6 سال پیش بسته شد
kjswis 6 سال پیش بازگشایی شد
kjswis 6 سال پیش بسته شد
درخواست pull request با موفقیت ادغام شد!
برای پیوستن به گفتگو، وارد شودید.
بدون برچسب
بدون نقطه عطف
بدون مسئول رسیدگی
2 مشارکت کننده
درحال بارگذاری...
لغو
ذخيره
هنوز محتوایی ایجاد نشده.