#6 pkmn-poll

已合併
kjswis 6 年之前 將 2 次代碼提交從 PMD/Polling合併至 PMD/master
尚未有任何內容
kjswis commented 6 年之前
所有者

Let's use ruby's .each instead of iterating with a integer variable

Should look more like

i = 0
optionsArray.each do |option|
  fields.push({ name: Emoji::LETTERS[i], value: "#{option}\n#{CharAppResponses::INLINE_SPACE}", inline: true })
  i += 1
end

instead of like: for b in 1..a-1 do

Then when you iterate to add reactions, you can say

j = 0
i.times do
  message.react(Emoji::LETTERS[j]
end

Though, for this one you probably can use for b in 0..a do if you really want to

None of this has to be exact, but its cleaner to use ruby's custom for loops for iterations instead of storing a bunch of numbers and iterating

After this is all changed, and rebased, we will also need to add the command description and options

Let's use ruby's `.each` instead of iterating with a integer variable Should look more like ```ruby i = 0 optionsArray.each do |option| fields.push({ name: Emoji::LETTERS[i], value: "#{option}\n#{CharAppResponses::INLINE_SPACE}", inline: true }) i += 1 end ``` instead of like: `for b in 1..a-1 do` Then when you iterate to add reactions, you can say ```ruby j = 0 i.times do message.react(Emoji::LETTERS[j] end ``` Though, for this one you probably can use `for b in 0..a do` if you really want to None of this has to be exact, but its cleaner to use ruby's custom for loops for iterations instead of storing a bunch of numbers and iterating After this is all changed, and rebased, we will also need to add the command description and options
kjswis6 年之前 關閉
kjswis6 年之前 重新開啟
kjswis6 年之前 關閉
該合併請求已經成功合併!
Sign in to join this conversation.
未選擇標籤
未選擇里程碑
未指派成員
2 參與者
正在加載...
取消
保存
尚未有任何內容